feat(valkey): add Valkey module#947
Conversation
|
Hi @alexanderankin, I opened this PR to add Valkey test container as mentioned in this ticket. Would appreciate a review when you have a moment. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 16 16
Lines 1700 1700
Branches 186 186
=======================================
Hits 1412 1412
Misses 234 234
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tranquility2
added
🛠️ needs more work
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
daric93
force-pushed
the
valkey_test_container
branch
from
4c8007b to
21ec9f8
Compare
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
|
@Tranquility2, please take another look when you have a chance: rebased onto latest main, addressed auto code review feedback, fixed CI issues. |
Tranquility2
removed
the
🛠️ needs more work
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
…ners-python into valkey_test_container
|
@Tranquility2, please take another look when you have a chance: fixed ci failures |
| self.waiting_for(ExecWaitStrategy(["valkey-cli", "-a", password, "ping"])) | ||
| return self | ||
|
|
||
| def with_image_tag(self, tag: str) -> "ValkeyContainer": |
There was a problem hiding this comment.
even if this code gets merged now, which im inclined to do to just clear the backlog, this will not survive into v5 which i want to do asap. this is a method that belongs on the docker image datastructure not on container (or even base container)
3 participants
I’d like to add Valkey, the open-source fork of Redis, as a dedicated Testcontainers module.